Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Foreport 6238 to inspec-6 #6280

Merged
merged 1 commit into from
Oct 20, 2022
Merged

Foreport 6238 to inspec-6 #6280

merged 1 commit into from
Oct 20, 2022

Conversation

Vasu1105
Copy link
Contributor

@Vasu1105 Vasu1105 commented Oct 20, 2022

faraday_middleware was already DEPRECATED in 2022-01. Only FaradayMiddleware::FollowRedirects from faraday_middleware has been used, and so we can replace it with faraday-follow_redirects.

faraday-follow_redirects 0.3.0 requires faraday ~> 1.0, which is as same as "faraday_middleware 1.0.0 or higher.

Signed-off-by: Takuya Noguchi takninnovationresearch@gmail.com

Description

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New content (non-breaking change)
  • Breaking change (a content change which would break existing functionality or processes)

Checklist:

  • I have read the CONTRIBUTING document.

faraday_middleware was already DEPRECATED in 2022-01.
Only FaradayMiddleware::FollowRedirects from faraday_middleware has been
used, and so we can replace it with faraday-follow_redirects.

faraday-follow_redirects 0.3.0 requires faraday ~> 1.0, which is as same
as "faraday_middleware 1.0.0 or higher.

Signed-off-by: Takuya Noguchi <takninnovationresearch@gmail.com>

Signed-off-by: Takuya Noguchi <takninnovationresearch@gmail.com>
@Vasu1105 Vasu1105 requested a review from a team as a code owner October 20, 2022 14:10
@Vasu1105 Vasu1105 changed the title Foreport 6238 Foreport 6238 to inspec-6 Oct 20, 2022
@clintoncwolfe clintoncwolfe merged commit 3e3b2c9 into inspec-6 Oct 20, 2022
@clintoncwolfe clintoncwolfe deleted the vasundhara/foreport-6238 branch October 20, 2022 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants