Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds missing expeditor configuration for inspec 6 release #6624

Merged

Conversation

Vasu1105
Copy link
Contributor

@Vasu1105 Vasu1105 commented Aug 24, 2023

Description

This contains missing configurations that will be required for the inspec 6 release

  • omnibus ad-hoc build
  • build gem
  • project promotion
  • publishing artifacts (rollover of changelog, publish rubygems, create github release, publish release notes, purge_packages_chef_io_fastly, announce release, notify_chefio_slack_channels)

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New content (non-breaking change)
  • Breaking change (a content change which would break existing functionality or processes)

Checklist:

  • I have read the CONTRIBUTING document.

@netlify
Copy link

netlify bot commented Aug 24, 2023

Deploy Preview for chef-inspec canceled.

Name Link
🔨 Latest commit 4b6952a
🔍 Latest deploy log https://app.netlify.com/sites/chef-inspec/deploys/64f065049b32990008419ef8

@Vasu1105 Vasu1105 changed the title Missing configurations which will be required for inspec 6 release Adds missing expeditor configuration which will be required for inspec 6 release Aug 24, 2023
@Vasu1105 Vasu1105 changed the title Adds missing expeditor configuration which will be required for inspec 6 release Adds missing expeditor configuration for inspec 6 release Aug 24, 2023
post_commit: true
- bash:.expeditor/announce-release.sh:
post_commit: true
- built_in:notify_chefio_slack_channels
- trigger_pipeline:omnibus/release:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is incorrect. omnibus/release should be triggered on merge, not on artifact_published(promote). That's how we get pre-release builds.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compare the config.yml on inspec-5 to see how the workflows are setup.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @clintoncwolfe. I have made the required changes.

- trigger_pipeline:omnibus/release:
only_if: built_in:bump_version
ignore_labels:
- "Expeditor: Skip Omnibus"
- "Expeditor: Skip All"
- built_in:build_gem:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we are failing Expeditor validation because we do not have a top-level rubygems section. We need to pull in the top-level rubygems section from the inspec-5 branch as well. It should have a config for inspec and inspec-bin.

Vasu1105 and others added 3 commits August 31, 2023 15:30
Signed-off-by: Vasu1105 <vasundhara.jagdale@chef.io>
Signed-off-by: Vasu1105 <vasundhara.jagdale@progress.com>
Signed-off-by: Vasu1105 <vasundhara.jagdale@progress.com>
@Vasu1105 Vasu1105 force-pushed the vasundhara/missing-expeditor-configuration-on-inspec-main branch from 5277535 to 4b6952a Compare August 31, 2023 10:01
@Vasu1105 Vasu1105 marked this pull request as ready for review August 31, 2023 10:13
@Vasu1105 Vasu1105 requested a review from a team as a code owner August 31, 2023 10:13
@clintoncwolfe clintoncwolfe merged commit 55d97e9 into main Aug 31, 2023
6 of 7 checks passed
@clintoncwolfe clintoncwolfe deleted the vasundhara/missing-expeditor-configuration-on-inspec-main branch August 31, 2023 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants