CHEF-3928 Fix in HTML2 reporter - unique ID usage for control HTML divisions #6645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for chef-inspec canceled.
|
clintoncwolfe
approved these changes
Oct 11, 2023
…sing profile id as prefix Signed-off-by: Nik08 <nikita.mathur@progress.com>
Nik08
force-pushed
the
nm/html-reporter-fix
branch
from
bfe39a9
to
d507e39
Compare
Nik08
added a commit
that referenced
this pull request
Oct 19, 2023
…sing profile id as prefix (#6645) Signed-off-by: Nik08 <nikita.mathur@progress.com>
Nik08
added a commit
that referenced
this pull request
Oct 19, 2023
…sing profile id as prefix (#6645) Signed-off-by: Nik08 <nikita.mathur@progress.com>
This was referenced Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix in HTML2 reporter - unique ID usage for control HTML divisions.
Because the same control ID was used in different dependent profiles for different controls, the checkboxes on HTML report were not working as expected. So a unique ID is created by adding a prefix of the profile name.
profile-<%= slugged_profile_id %>-control-<%= slugged_control_id %>Related Issue
Types of changes
Checklist: