CHEF-7670 Ability to set feature preview flag using ENV #6833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nik08 <nikita.mathur@progress.com>
✅ Deploy Preview for chef-inspec canceled.
|
Signed-off-by: Nik08 <nikita.mathur@progress.com>
Nik08
force-pushed
the
nm/feature-flag
branch
from
404e74a
to
66e7254
Compare
Signed-off-by: Nik08 <nikita.mathur@progress.com>
Nik08
force-pushed
the
nm/feature-flag
branch
from
89300ed
to
0cbc8db
Compare
Nik08
changed the title
Nik08
changed the title
clintoncwolfe
approved these changes
Oct 30, 2023
Signed-off-by: Nik08 <nikita.mathur@progress.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ability to set feature preview flag using ENV. This extends the functionality of the existing Inspec feature subsystem if some feature execution needs to be conditionalised.
Details:
This subsystem uses
env_preview: true or env_preview: false, set in the config fileetc/features.yamlto determine if a feature is previewable or not.env_preview: true, then the feature block is only executed if the ENV valueCHEF_PREVIEW_#{FEATURE_NAME}is set in the environment.env_preview: false, then the feature block is not executed.In all the other scenarios, the behaviour is unaltered, i.e. it always executes block.
Note
Dev docs for the feature subsystem can be covered separately since a doc on this subsystem does not exist now.
Usage of a feature flag from a user perspective can be updated on a per-feature basis. The first flag will be introduced with PR #6705
Related Issue
Types of changes
Checklist: