Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Update configuration to pick commercial license to be used during the buildkite test #7007

Merged
merged 6 commits into from
May 31, 2024

Conversation

ahasunos
Copy link
Contributor

@ahasunos ahasunos commented Apr 4, 2024

Description

This PR updates the configuration to pick commercial license to be used during the CI test.

This is required because the PR chef/chef-licensing#175 introduces a warning message for non-commercial users. The existing license on the CI is a trial license which causes failure of our tests on the CI.

Related Issue

CHEF-10498: Modify CLI reporter to show message regarding licensing to free and trial users

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New content (non-breaking change)
  • Breaking change (a content change which would break existing functionality or processes)

Checklist:

  • I have read the CONTRIBUTING document.

@ahasunos ahasunos requested a review from a team as a code owner April 4, 2024 06:42
@ahasunos ahasunos requested review from Vasu1105 and Nik08 April 4, 2024 06:42
Copy link

netlify bot commented Apr 4, 2024

Deploy Preview for chef-inspec canceled.

Name Link
🔨 Latest commit a808c98
🔍 Latest deploy log https://app.netlify.com/sites/chef-inspec/deploys/6644b05d92cd26000843b64a

Signed-off-by: Sonu Saha <sonu.saha@progress.com>
@ahasunos ahasunos force-pushed the ss/warn-message-non-commercial-users branch from 737eb2c to c7c8659 Compare April 24, 2024 08:12
@ahasunos ahasunos changed the title [WIP]CHEF-10498: Invoke warning message for non-commercial users if reporter is cli CHEF-10498: Invoke warning message for non-commercial users if reporter is cli Apr 24, 2024
Signed-off-by: Sonu Saha <sonu.saha@progress.com>
Signed-off-by: Sonu Saha <sonu.saha@progress.com>
Signed-off-by: Sonu Saha <sonu.saha@progress.com>
Signed-off-by: Sonu Saha <sonu.saha@progress.com>
@ahasunos ahasunos force-pushed the ss/warn-message-non-commercial-users branch from e291a50 to b3d2413 Compare May 14, 2024 08:13
@Nik08
Copy link
Contributor

Nik08 commented May 15, 2024

Looks good to me, we should just merge it once we get the commercial license for CI.

@ahasunos ahasunos changed the title CHEF-10498: Invoke warning message for non-commercial users if reporter is cli CI: Update expeditor configuration to pick commercial license to be used during the CI test May 15, 2024
@ahasunos ahasunos changed the title CI: Update expeditor configuration to pick commercial license to be used during the CI test CI: Update configuration to pick commercial license to be used during the buildkite test May 15, 2024
Signed-off-by: Sonu Saha <sonu.saha@progress.com>
Copy link
Contributor

@Vasu1105 Vasu1105 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Echoing @Nik08

@Vasu1105
Copy link
Contributor

We will merge this for now. And we will update the test commercial license key in the vault once we get that. Currently dummy commercial license is on the vault that we are using will be expired on 23rd August 2024. cc. @ahasunos

@Vasu1105 Vasu1105 merged commit 8f50a2d into main May 31, 2024
11 of 12 checks passed
@Vasu1105 Vasu1105 deleted the ss/warn-message-non-commercial-users branch May 31, 2024 09:01
chef-expeditor bot pushed a commit that referenced this pull request May 31, 2024
Obvious fix; these changes are the result of automation not creative thinking.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants