Adding proper bastion support #310
Conversation
Signed-off-by: Noel Georgi <18496730+frezbo@users.noreply.github.com>
lib/train/transports/ssh.rb
Outdated
| @@ -150,7 +158,10 @@ def connection_options(opts) | |||
| keys: opts[:key_files], | |||
| password: opts[:password], | |||
| forward_agent: opts[:forward_agent], | |||
| proxy_command: opts[:proxy_command], | |||
| custom_proxy_command: opts[:custom_proxy_command], | |||
There was a problem hiding this comment.
I think this will break any current proxy_command usage. You could probably alias or set custom_proxy_command from proxy_command if set.
There was a problem hiding this comment.
yeh I definitely agree, will fix.
There was a problem hiding this comment.
@jquick I can't seem to think why I used a custom prefix then. Good suggestion. Fixed and pushed. Thanks for the suggestion.
Signed-off-by: Noel Georgi <18496730+frezbo@users.noreply.github.com>
Signed-off-by: Noel Georgi <18496730+frezbo@users.noreply.github.com>
|
The failure seems unrelated to my change. |
|
Closing and re-opening to re-trigger the tests |
|
@jquick Is there a new release being scheduled? I would like to add the same support to inspec and bump up the train version. Is there any place we can discuss this. Inspec slack? (Ironically it's still down ATM) 👍 |
|
We will release train Thursday, ill take care of getting it pined up! Thanks @frezbo! I am also around the community chef slack when it up :D. |
|
Thanks @jquick time to start on inspec. |
Signed-off-by: Noel Georgi <18496730+frezbo@users.noreply.github.com>
* Updating inspec with bastion options as per inspec/train#310 * Updating train pin * Adding --password to pass the test * Revert "Updating train pin" * PR changes Signed-off-by: Noel Georgi <18496730+frezbo@users.noreply.github.com>
This PR addresses these issues:
If the skeleton is good, I could raise PR's that reference these:
@clintoncwolfe @jquick @aaronlippold @chris-rock Any thoughts or suggestions?