fix some bugs, close #41 #42
Conversation
|
@ljharb PTAL |
Codecov ReportBase: 95.02% // Head: 90.80% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #42 +/- ##
==========================================
- Coverage 95.02% 90.80% -4.23%
==========================================
Files 2 2
Lines 342 337 -5
Branches 147 145 -2
==========================================
- Hits 325 306 -19
- Misses 17 31 +14
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
| @@ -0,0 +1,9 @@ | |||
| interface opts { | |||
| quoteStyle?: 'single' | 'double' | |||
There was a problem hiding this comment.
Types don’t belong in the package; they should only be in DefinitelyTyped.
| @@ -65,10 +65,6 @@ function addNumericSeparator(num, str) { | |||
| return $replace.call(str, sepRegex, '$&_'); | |||
| } | |||
|
|
|||
| var utilInspect = require('./util.inspect'); | |||
There was a problem hiding this comment.
This is incorrect; the util module is always present, and the browser field handles that for working bundlers.
| @@ -3,14 +3,15 @@ | |||
| "version": "1.12.2", | |||
| "description": "string representations of objects in node and the browser", | |||
| "main": "index.js", | |||
| "typings": "index.d.ts", | |||
|
Thanks for the review. I agree with your thoughts. This PR should be closed. |
Fixes #41
Other:
feat: add dts
chore: upgrade dep