Tests for negative zero (-0) #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
requested changes
Oct 31, 2016
| @@ -7,10 +7,3 @@ test('function', function (t) { | |||
| t.equal(inspect(obj), '[ 1, 2, [Function: f], 4 ]'); | |||
| }); | |||
|
|
|||
| test('function name', function (t) { | |||
There was a problem hiding this comment.
looks like this test fails in master on node 6+ due to function name inference.
I'll fix this in master rather than just removing the test here.
| @@ -33,6 +33,14 @@ module.exports = function inspect_ (obj, opts, depth, seen) { | |||
| if (typeof obj === 'string') { | |||
| return inspectString(obj); | |||
| } | |||
| if (typeof obj === 'number') { | |||
| if (Object.is) { | |||
There was a problem hiding this comment.
this should still pass when Object.is is not present - it'd probably be simpler to do:
if (obj === 0) {
return Infinity / obj > 0 ? '0' : '-0';
}There was a problem hiding this comment.
Surprisingly, Object.is is present as far back as node 0.8 :-). I've made this change so it works in 0.6.
ljharb
approved these changes
Jan 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had to disable a test that's failing in master. I tried to fix it initially, but I don't quite understand why it's not working.