Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added a description of bulding the docker image for local use and how… #22

Merged
merged 1 commit into from
Jan 10, 2023

Conversation

Dimi-Ma
Copy link
Member

@Dimi-Ma Dimi-Ma commented Jan 10, 2023

… to create a release in the readme


This change is Reviewable

Copy link
Contributor

@quandor quandor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 2 files at r1, all commit messages.
Reviewable status: 1 of 2 files reviewed, 3 unresolved discussions (waiting on @Dimi-Ma)


README.md line 283 at r1 (raw file):

Local Docker Image

Change to Build Docker Image Locally


README.md line 284 at r1 (raw file):

##### Local Docker Image
How to build the docker container for local use.

Remove that sentence.


README.md line 291 at r1 (raw file):

##### How to Release
To create a new release, you have to create a new git tag and push it on to GitHub. 
This Tag is the new version number of the release. Afterwards the actions will be automatically triggered.

I would change Afterwards the actions will be automatically triggered. to Afterwards the release build will be automatically triggered.

Copy link
Member Author

@Dimi-Ma Dimi-Ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dismissed @quandor from a discussion.
Reviewable status: 1 of 2 files reviewed, 2 unresolved discussions (waiting on @quandor)


README.md line 283 at r1 (raw file):

Previously, quandor (Jochen Just) wrote…

Change to Build Docker Image Locally

Done.


README.md line 284 at r1 (raw file):

Previously, quandor (Jochen Just) wrote…

Remove that sentence.

done


README.md line 291 at r1 (raw file):

Previously, quandor (Jochen Just) wrote…

I would change Afterwards the actions will be automatically triggered. to Afterwards the release build will be automatically triggered.

Done.

Copy link
Contributor

@quandor quandor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Dimi-Ma)

@Dimi-Ma Dimi-Ma merged commit e8fd94f into main Jan 10, 2023
@Dimi-Ma Dimi-Ma deleted the updateReadme branch January 10, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants