Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #32 - Implementation of Github Action that generates the release changelog how it was previously done #33

Merged
merged 9 commits into from
Mar 27, 2023

Conversation

danipaniii
Copy link
Contributor

@danipaniii danipaniii commented Feb 16, 2023

Implementation of Github Action that generates the release how it was previously done.


This change is Reviewable

@danipaniii danipaniii changed the title Closes #32 - Implementation of Github Action that generates the release how it was previously done Closes #32 - Implementation of Github Action that generates the release changelog how it was previously done Feb 16, 2023
Copy link
Contributor

@heiko-holz heiko-holz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @danipaniii)


.github/workflows/eumserver_release.yml line 46 at r1 (raw file):

            sinceTag: ${{ steps.previoustag.outputs.tag }} 
            dateFormat: 
            maxIssues: 500

we need to watch if we exceed the secondary rate limit for GitHub API request once we apply this to the Ocelot Agent repo


.github/workflows/eumserver_release.yml line 47 at r1 (raw file):

            dateFormat: 
            maxIssues: 500
            unreleased: false

do you know by chance what this actually means?
The docu says "Add to log unreleased closed issues.", but what are unreleased closed issues?
Issues that are not connected to any PR but were closed in the respective time frame?

Code quote:

heinrichreimer/github-changelog-generator-action

.github/workflows/eumserver_release.yml line 57 at r1 (raw file):

            body: ${{ steps.build_changelog.outputs.changelog }}
            files: artifacts/*
            generate_release_notes: false

did this ever work?

Code quote:

softprops/action-gh-release

Copy link
Contributor

@quandor quandor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @danipaniii)

Copy link
Contributor

@quandor quandor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 3 files at r1, 1 of 1 files at r2.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @danipaniii)

@quandor quandor merged commit 61b4166 into inspectIT:main Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] - Idea to change changelog generation - Github Action Release
3 participants