Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update changelog generator action to fix deprecated warning #38

Merged
merged 2 commits into from
Apr 6, 2023

Conversation

danipaniii
Copy link
Contributor

@danipaniii danipaniii commented Apr 4, 2023

Closes #37


This change is Reviewable

Copy link
Contributor

@quandor quandor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @danipaniii)


.github/workflows/eumserver_release.yml line 17 at r1 (raw file):

    needs: [test_eum_server]
    steps:
    - name: Checkout code

I am not sure, that this indentation is correct. AFAIK list items in yaml need to be indented a level.

Copy link
Contributor

@quandor quandor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @danipaniii)

Copy link
Contributor Author

@danipaniii danipaniii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @quandor)


.github/workflows/eumserver_release.yml line 17 at r1 (raw file):

Previously, quandor (Jochen Just) wrote…

I am not sure, that this indentation is correct. AFAIK list items in yaml need to be indented a level.

I forgot to save it with disabling the auto-fromat by vs code. I fixed it.

Copy link
Contributor

@quandor quandor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @danipaniii)

@quandor quandor merged commit d4f1545 into inspectIT:main Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] - Fix 'set-output' warning when generating changelog
2 participants