Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] - No default sample-mode for auto tracing settings #1565

Closed
heiko-holz opened this issue Jan 23, 2023 · 0 comments · Fixed by #1566
Closed

[Bug] - No default sample-mode for auto tracing settings #1565

heiko-holz opened this issue Jan 23, 2023 · 0 comments · Fixed by #1566
Labels
bug Something isn't working

Comments

@heiko-holz
Copy link
Contributor

Describe the bug
No default value for sample-mode is used for auto tracing.
As described in https://github.com/inspectIT/inspectit-ocelot/blob/master/inspectit-ocelot-documentation/docs/instrumentation/rules.md, HYBRID_PARENT_TRACE_ID_RATIO_BASED should be set as the default sample-mode, but currently, the default sample-mode is null.

To Reproduce
Enable auto-tracing, set sample-probability, but do not set the sample-mode.

Expected behavior
The sample-mode should be HYBRID_PARENT_TRACE_ID_RATIO_BASED by default.
@heiko-holz heiko-holz added the bug Something isn't working label Jan 23, 2023
@heiko-holz heiko-holz mentioned this issue Jan 23, 2023
Merged
heiko-holz pushed a commit to heiko-holz/inspectit-ocelot that referenced this issue Jan 23, 2023
fix(auto-tracing): set default sample-mode [inspectIT#1565]
d3ddc11
@heiko-holz heiko-holz mentioned this issue Jan 23, 2023
Merged
heiko-holz pushed a commit to heiko-holz/inspectit-ocelot that referenced this issue Jan 24, 2023
fix(auto-tracing): refactoring according to PR reviews [inspectIT#1565]
6d5c28d
heiko-holz pushed a commit that referenced this issue Jan 24, 2023
Closes #1565: [Bug] - No default sample-mode for auto tracing settings (
2b6a595 
#1566)

* fix(auto-tracing): set default sample-mode [#1565]

* fix(auto-tracing): refactoring according to PR reviews [#1565]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Closes #1565: [Bug] - No default sample-mode for auto tracing settings heiko-holz/inspectit-ocelot
1 participant
@heiko-holz