Closes #61 - Implemented binding and execution of data providers #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivansenic
reviewed
Feb 21, 2019
inspectit-oce-agent/src/system-test/resources/config/agent-overwrites.yml
Show resolved
Hide resolved
...t-oce-core/src/main/java/rocks/inspectit/oce/core/instrumentation/AsyncClassTransformer.java
Show resolved
Hide resolved
...in/java/rocks/inspectit/oce/core/instrumentation/config/MethodHookConfigurationResolver.java
Show resolved
Hide resolved
...in/java/rocks/inspectit/oce/core/instrumentation/dataprovider/generic/BoundDataProvider.java
Outdated
Show resolved
Hide resolved
...in/java/rocks/inspectit/oce/core/instrumentation/dataprovider/generic/BoundDataProvider.java
Show resolved
Hide resolved
inspectit-oce-core/src/main/java/rocks/inspectit/oce/core/instrumentation/hook/HookManager.java
Outdated
Show resolved
Hide resolved
...ce-core/src/main/java/rocks/inspectit/oce/core/instrumentation/hook/MethodHookGenerator.java
Outdated
Show resolved
Hide resolved
ivansenic
approved these changes
Feb 22, 2019
There was a problem hiding this comment.
I tried to instrument the app, it's not so trivial to have the configuration defined by just using the YML files.. But it works very well, I even wrote a data provider that extracts the interesting stuff out of application context.. I would advise that @mariusoe has a look as well before you more this..
mariusoe
approved these changes
Feb 25, 2019
...in/java/rocks/inspectit/oce/core/instrumentation/config/MethodHookConfigurationResolver.java
Show resolved
Hide resolved
...in/java/rocks/inspectit/oce/core/instrumentation/dataprovider/generic/BoundDataProvider.java
Outdated
Show resolved
Hide resolved
...in/java/rocks/inspectit/oce/core/instrumentation/dataprovider/generic/BoundDataProvider.java
Outdated
Show resolved
Hide resolved
...va/rocks/inspectit/oce/core/instrumentation/config/InstrumentationConfigurationResolver.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.