Closes #1180 - The configuration server does not use custom private keys for authenticating Git fetches #1190
Conversation
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @Patrick-Eichhorn)
components/inspectit-ocelot-configurationserver/src/main/java/rocks/inspectit/ocelot/file/versioning/RemoteConfigurationManager.java, line 240 at r1 (raw file):
Decides what type of authentication is performed.
Decides what... expresses rather as that something is returned or determined, instead of that something is done.
Just say whats happening Authenticates the given command with a password or PPK authentication, depending on the given remote repository setting..
components/inspectit-ocelot-configurationserver/src/main/java/rocks/inspectit/ocelot/file/versioning/RemoteConfigurationManager.java, line 245 at r1 (raw file):
authenticate
Imo authenticateCommand would be more expressive.
There was a problem hiding this comment.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @Patrick-Eichhorn)
closes #1180
This change is