Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move EUM server to separate repo #1427

Merged
merged 4 commits into from Jun 2, 2022

Conversation

aaronweissler
Copy link
Member

@aaronweissler aaronweissler commented May 9, 2022

Closes #1426
See also corresponding PR in new repo inspectIT/inspectit-ocelot-eum-server#1


This change is Reviewable

@codecov
Copy link

codecov bot commented May 9, 2022

Codecov Report

Merging #1427 (0b70c6a) into master (00ee1e3) will increase coverage by 0.01%.
The diff coverage is 73.53%.

@@             Coverage Diff              @@
##             master    #1427      +/-   ##
============================================
+ Coverage     79.09%   79.10%   +0.01%     
+ Complexity     2233     2228       -5     
============================================
  Files           232      232              
  Lines          7240     7252      +12     
  Branches        859      860       +1     
============================================
+ Hits           5726     5736      +10     
- Misses         1157     1158       +1     
- Partials        357      358       +1     
Impacted Files Coverage Δ
...it/ocelot/core/exporter/JaegerExporterService.java 66.10% <66.67%> (-6.24%) ⬇️
...ore/opentelemetry/OpenTelemetryControllerImpl.java 78.12% <100.00%> (ø)
...nspectit/ocelot/core/utils/OpenTelemetryUtils.java 61.90% <0.00%> (+11.90%) ⬆️

Copy link
Contributor

@heiko-holz heiko-holz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 95 of 95 files at r1, 4 of 4 files at r2.
Reviewable status: 98 of 99 files reviewed, all discussions resolved (waiting on @heiko-holz)

Copy link
Contributor

@heiko-holz heiko-holz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 98 of 99 files reviewed, all discussions resolved (waiting on @heiko-holz)

Copy link
Contributor

@heiko-holz heiko-holz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @aaronweissler)

@heiko-holz heiko-holz merged commit 3cb6958 into inspectIT:master Jun 2, 2022
@aaronweissler aaronweissler deleted the remove-eum-server branch June 7, 2022 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move EUM Server to individual repo
2 participants