Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #1465 - Since 2.0.0 Wildfy Server refuses to start #1467

Merged
merged 1 commit into from Jun 13, 2022

Conversation

ClaudioWaldvogel
Copy link
Contributor

@ClaudioWaldvogel ClaudioWaldvogel commented Jun 10, 2022

Removed Logger intialization from AgentMain.java
Made EnvironmentInformationPropertySource#getAgentJarDirectory Wildfly save


This change is Reviewable

…ormationPropertySource#getAgentJarDirectory Wildfyl save
@codecov
Copy link

codecov bot commented Jun 10, 2022

Codecov Report

Merging #1467 (53e783e) into master (bcf0d1c) will decrease coverage by 0.10%.
The diff coverage is 87.27%.

@@             Coverage Diff              @@
##             master    #1467      +/-   ##
============================================
- Coverage     79.05%   78.95%   -0.10%     
+ Complexity     2228     2223       -5     
============================================
  Files           232      228       -4     
  Lines          7252     7236      -16     
  Branches        860      859       -1     
============================================
- Hits           5733     5713      -20     
- Misses         1160     1165       +5     
+ Partials        359      358       -1     
Impacted Files Coverage Δ
...n/java/rocks/inspectit/ocelot/agent/AgentMain.java 47.46% <0.00%> (-0.88%) ⬇️
...tation/actions/template/GenericActionTemplate.java 0.00% <0.00%> (ø)
...on/actions/template/VoidGenericActionTemplate.java 0.00% <0.00%> (ø)
...in/java/rocks/inspectit/ocelot/core/AgentImpl.java 61.11% <40.00%> (-10.32%) ⬇️
...trumentation/actions/bound/BoundGenericAction.java 87.50% <94.44%> (+4.17%) ⬆️
...rocks/inspectit/ocelot/bootstrap/AgentManager.java 66.67% <100.00%> (+4.17%) ⬆️
...ysources/EnvironmentInformationPropertySource.java 67.74% <100.00%> (ø)
...nstrumentation/actions/GenericActionGenerator.java 97.30% <100.00%> (-0.14%) ⬇️
.../actions/bound/ConstantOnlyBoundGenericAction.java 100.00% <100.00%> (ø)
...ation/actions/bound/DynamicBoundGenericAction.java 89.47% <100.00%> (ø)
... and 8 more

@mariusoe mariusoe changed the title Closes #1465 [Feature] - Since 2.0.0 Wildfy Server refuses to start Closes #1465 - Since 2.0.0 Wildfy Server refuses to start Jun 13, 2022
Copy link
Member

@mariusoe mariusoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ClaudioWaldvogel)

Copy link
Member

@mariusoe mariusoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ClaudioWaldvogel)


inspectit-ocelot-agent/src/main/java/rocks/inspectit/ocelot/agent/AgentMain.java line 73 at r1 (raw file):

        // check for deprecated JVM property
        if (null != System.getProperty(PUBLISH_OPEN_CENSUS_TO_BOOTSTRAP_PROPERTY)) {
            System.err.println("You are using the deprecated JVM property '" + PUBLISH_OPEN_CENSUS_TO_BOOTSTRAP_PROPERTY + "'. Please use the new JVM property '" + PUBLISH_OPEN_TELEMETRY_TO_BOOTSTRAP_PROPERTY + "'. inspectIT Ocelot has moved from OpenCensus to OpenTelemetry. However, applications using the OpenCensusAPI are still supported through the opentelemetry-opencensus-shim ");

Test!

Copy link
Member

@mariusoe mariusoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ClaudioWaldvogel)

@mariusoe mariusoe merged commit bf1e817 into inspectIT:master Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants