New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closes #1465 - Since 2.0.0 Wildfy Server refuses to start #1467
Closes #1465 - Since 2.0.0 Wildfy Server refuses to start #1467
Conversation
…ormationPropertySource#getAgentJarDirectory Wildfyl save
Codecov Report
@@ Coverage Diff @@
## master #1467 +/- ##
============================================
- Coverage 79.05% 78.95% -0.10%
+ Complexity 2228 2223 -5
============================================
Files 232 228 -4
Lines 7252 7236 -16
Branches 860 859 -1
============================================
- Hits 5733 5713 -20
- Misses 1160 1165 +5
+ Partials 359 358 -1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ClaudioWaldvogel)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ClaudioWaldvogel)
inspectit-ocelot-agent/src/main/java/rocks/inspectit/ocelot/agent/AgentMain.java
line 73 at r1 (raw file):
// check for deprecated JVM property if (null != System.getProperty(PUBLISH_OPEN_CENSUS_TO_BOOTSTRAP_PROPERTY)) { System.err.println("You are using the deprecated JVM property '" + PUBLISH_OPEN_CENSUS_TO_BOOTSTRAP_PROPERTY + "'. Please use the new JVM property '" + PUBLISH_OPEN_TELEMETRY_TO_BOOTSTRAP_PROPERTY + "'. inspectIT Ocelot has moved from OpenCensus to OpenTelemetry. However, applications using the OpenCensusAPI are still supported through the opentelemetry-opencensus-shim ");
Test!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ClaudioWaldvogel)
Removed Logger intialization from AgentMain.java
Made EnvironmentInformationPropertySource#getAgentJarDirectory Wildfly save
This change is