-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug #1479: Configuration UI overlaps Combined-Services-Badge and Show-Logs-Icon #1489
Conversation
… and Show-Logs-Icon
Will be discussed in the week of 29.08-02.09.2022 when I'm in FFM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @heiko-holz and @MariusBrill)
In order to always show the full name of the service name and not having to hover over it, there is the possibility to change the styling like this: |
We discussed in the team and decided for the version with the line-break. |
…the full name is always displayed and before it would surpass the column box, the name continues on a new line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 2 files at r4, 1 of 1 files at r5, 2 of 2 files at r6, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @MariusBrill and @sbraitsch)
components/inspectit-ocelot-configurationserver-ui/src/components/views/status/StatusTable.js
line 188 at r6 (raw file):
} .this :global(.might-overflow):hover {
do we even need the agent name on hover?
I.e., can we remove the title
for the agent name?
Let's discuss this in today's sync
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r7, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @MariusBrill)
components/inspectit-ocelot-configurationserver-ui/src/components/views/status/StatusTable.js
line 188 at r6 (raw file):
Previously, heiko-holz (Heiko Holz) wrote…
do we even need the agent name on hover?
I.e., can we remove thetitle
for the agent name?
Let's discuss this in today's sync
As discussed, I removed the hover
attribute and related CSS class
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @MariusBrill)
Closes #1479
Added a max width to the name template. Name + ID combinations that are too long will get ellipsized to prevent overlap.
I also moved the service-count badge statically next to the show log and show config icons to make the position consistent.
Added the name + id as a tooltip, so it can be seen fully even when it gets ellipsized.
This change is