Closes #1187: Extend the configuration UI to be able to hide files

[marcel-haag]

closes #1187

This change is 

[MariusBrill]

Reviewed 1 of 5 files at r1, 6 of 6 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @marcel-haag and @mariusoe)

---

components/inspectit-ocelot-configurationserver-ui/src/redux/ducks/configuration/actions.js line 269 at r2 (raw file):

      hideFilesRecursively(files, hidePattern);
    } else {
      dispatch(fetchFiles());

Why do we need to fetch the files when showHiddenFiles is false?

[heiko-holz]

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @marcel-haag and @mariusoe)

[heiko-holz]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @marcel-haag and @mariusoe)

[heiko-holz]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @MariusBrill and @mariusoe)

---

components/inspectit-ocelot-configurationserver-ui/src/redux/ducks/configuration/actions.js line 269 at r2 (raw file):

Previously, MariusBrill (Marius Brill) wrote…

Why do we need to fetch the files when showHiddenFiles is false?

because we toggle from showHiddenFiles to !showHiddenFiles.

But I see your point. Doing the toggle before and then negating the expression makes more sense.

I've pushed an update.

[aaronweissler]

Reviewable status: 4 of 9 files reviewed, 1 unresolved discussion (waiting on @heiko-holz, @marcel-haag, @MariusBrill, and @mariusoe)

a discussion (no related file):
When I create a new file or folder while hidden files are not shown, they all appear again. I assume it is because in the writeFile action the fetchFiles action is dispatched as well.
Maybe the hiding could be incorporated into the fetchFiles action directly?

I also wonder if the default should be that the hidden files are not shown, so they are only shown when explicitly asked for?

---

[heiko-holz]

a discussion (no related file):

Previously, aaronweissler wrote…

When I create a new file or folder while hidden files are not shown, they all appear again. I assume it is because in the writeFile action the fetchFiles action is dispatched as well.
Maybe the hiding could be incorporated into the fetchFiles action directly?

I also wonder if the default should be that the hidden files are not shown, so they are only shown when explicitly asked for?

Good point, thank you for the comment!

I have refactored toggleShowHiddenFiles and incorporated it in fetchFiles.

Let's discuss the default state in the next meeting.

[heiko-holz]

a discussion (no related file):

Previously, heiko-holz (Heiko Holz) wrote…

Good point, thank you for the comment!

I have refactored toggleShowHiddenFiles and incorporated it in fetchFiles.

Let's discuss the default state in the next meeting.

The default state was now changed to false, i.e., hidden files are not shown per default

[heiko-holz]

Reviewed 3 of 4 files at r5, 3 of 3 files at r7, 1 of 1 files at r8, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @aaronweissler and @mariusoe)

[aaronweissler]

Reviewed all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @mariusoe)

[heiko-holz]

Reviewed 1 of 1 files at r9, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @mariusoe)

[heiko-holz]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @mariusoe)

[MariusBrill]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @mariusoe)