-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closes #1512: [Feature] - Update otel-collector image used in integration tests to latest #1514
Closes #1512: [Feature] - Update otel-collector image used in integration tests to latest #1514
Conversation
…estBase * upgrade the otelcol image * set compression to 'none' in the otlp exporter defined in otel-colfig.yaml
…estBase * upgrade the otelcol image * set compression to 'none' in the otlp exporter defined in otel-colfig.yaml
…update-otel-collector-image' Conflicts: inspectit-ocelot-core/src/test/java/rocks/inspectit/ocelot/core/exporter/ExporterServiceIntegrationTestBase.java
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1514 +/- ##
============================================
- Coverage 78.64% 77.85% -0.78%
Complexity 2271 2271
============================================
Files 232 233 +1
Lines 7438 7514 +76
Branches 887 894 +7
============================================
+ Hits 5849 5850 +1
- Misses 1219 1295 +76
+ Partials 370 369 -1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @heiko-holz)
inspectit-ocelot-core/src/test/java/rocks/inspectit/ocelot/core/exporter/ExporterServiceIntegrationTestBase.java
line 65 at r1 (raw file):
// This image was used previously. // static final String COLLECTOR_IMAGE = "ghcr.io/open-telemetry/opentelemetry-java/otel-collector@sha256:d34519458388e55a3fce38a33e6bc424267c1f432927c09e932ba45f7575bd84"; //"otel/opentelemetry-collector";//
I would probably remove these comments, since it works just as well with the new image and if someone actually wants to know, they can still look through the git history.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 3 of 4 files reviewed, 1 unresolved discussion (waiting on @aaronweissler)
inspectit-ocelot-core/src/test/java/rocks/inspectit/ocelot/core/exporter/ExporterServiceIntegrationTestBase.java
line 65 at r1 (raw file):
Previously, aaronweissler wrote…
I would probably remove these comments, since it works just as well with the new image and if someone actually wants to know, they can still look through the git history.
I agree and I removed the comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @heiko-holz)
Closes #1512
Upgrade the image used for the OpenTelemetry Collector (contrib) in the exporter integration tests.
none
in the otlp exporter defined in otel-colfig.yaml (from v0.44.0 to v0.45.0, the default compression of the otlp exporter of the OpenTelemetry Collector was changed togzip
)This change is![Reviewable](https://camo.githubusercontent.com/23b05f5fb48215c989e92cc44cf6512512d083132bd3daf689867c8d9d386888/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)