Upgrade OpenTelemetry to v1.17.0 #1515
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1515 +/- ##
============================================
+ Coverage 77.51% 77.52% +0.01%
Complexity 2319 2319
============================================
Files 240 240
Lines 7728 7730 +2
Branches 923 924 +1
============================================
+ Hits 5990 5992 +2
Misses 1351 1351
Partials 387 387
|
There was a problem hiding this comment.
Reviewed 10 of 11 files at r1, all commit messages.
Reviewable status: 10 of 11 files reviewed, 1 unresolved discussion (waiting on @ClaudioWaldvogel and @heiko-holz)
inspectit-ocelot-core/src/main/java/rocks/inspectit/ocelot/core/opentelemetry/OpenTelemetryControllerImpl.java line 408 at r1 (raw file):
// register metric reader for each service for (DynamicallyActivatableMetricsExporterService metricsExportService : registeredMetricExporterServices.values()) { builder.registerMetricReader(OpenCensusMetrics.attachTo(metricsExportService.getNewMetricReader()));//OpenCensusMetrics.attachTo(metricsExportService.getNewMetricReader()));
the comment can be removed.
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @heiko-holz)
heiko-holz
force-pushed
the
features/feat-upgrade-otel-v1.17.0
branch
from
adbc023
to
009c541
Compare
There was a problem hiding this comment.
Reviewable status: 8 of 12 files reviewed, all discussions resolved (waiting on @Dimi-Ma)
inspectit-ocelot-core/src/main/java/rocks/inspectit/ocelot/core/opentelemetry/OpenTelemetryControllerImpl.java line 408 at r1 (raw file):
Previously, Dimi-Ma (Dimitiros Mantas) wrote…
the comment can be removed.
comment was removed
There was a problem hiding this comment.
Reviewed 4 of 4 files at r3, all commit messages.
Reviewable status:
There was a problem hiding this comment.
Reviewable status:
Upgrade OpenTelemetry to v1.17.0
This change is