Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #1534 and #1535 - Otlp*ExporterService does not expose underlying OTEL configuration #1536

Merged
merged 3 commits into from
Nov 11, 2022

Conversation

Dimi-Ma
Copy link
Member

@Dimi-Ma Dimi-Ma commented Nov 10, 2022

Closes #1534 and #1535


This change is Reviewable

@codecov
Copy link

codecov bot commented Nov 10, 2022

Codecov Report

Merging #1536 (b9b9436) into master (4ae7a26) will decrease coverage by 0.79%.
The diff coverage is 25.44%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1536      +/-   ##
============================================
- Coverage     78.64%   77.85%   -0.79%     
- Complexity     2271     2285      +14     
============================================
  Files           232      235       +3     
  Lines          7438     7570     +132     
  Branches        887      902      +15     
============================================
+ Hits           5849     5893      +44     
- Misses         1219     1309      +90     
+ Partials        370      368       -2     
Impacted Files Coverage Δ
.../src/main/java/com/mindprod/jarcheck/JarCheck.java 0.00% <0.00%> (ø)
...ocelot/core/exporter/OtlpTraceExporterService.java 66.67% <73.33%> (+1.80%) ⬆️
...elot/core/exporter/OtlpMetricsExporterService.java 69.49% <75.00%> (+3.64%) ⬆️
...elot/config/model/exporters/CompressionMethod.java 100.00% <100.00%> (ø)
...service/DynamicallyActivatableServiceObserver.java 50.00% <0.00%> (ø)
.../propertysources/http/HttpPropertySourceState.java 77.86% <0.00%> (+0.17%) ⬆️
...ot/core/service/DynamicallyActivatableService.java 83.72% <0.00%> (+0.79%) ⬆️
.../ocelot/core/metrics/system/GCMetricsRecorder.java 72.95% <0.00%> (+0.82%) ⬆️
...ot/core/instrumentation/AsyncClassTransformer.java 85.45% <0.00%> (+0.91%) ⬆️
... and 3 more

Copy link
Contributor

@ClaudioWaldvogel ClaudioWaldvogel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 13 of 13 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Dimi-Ma, @heiko-holz, and @quandor)

@ClaudioWaldvogel ClaudioWaldvogel merged commit bdaecd6 into master Nov 11, 2022
@heiko-holz heiko-holz changed the title Closes #1534 and #1536 - Otlp*ExporterService does not expose underlying OTEL configuration Closes #1534 and #1535 - Otlp*ExporterService does not expose underlying OTEL configuration Nov 14, 2022
@quandor quandor deleted the OtlpExposeConfigFix branch April 24, 2023 09:10
@quandor quandor restored the OtlpExposeConfigFix branch April 24, 2023 09:10
@quandor quandor deleted the OtlpExposeConfigFix branch April 24, 2023 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] - OtlpMetricsExporterService does not expose configruations for underlying
4 participants