Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding integration tests for DynamicallyActivatableServiceObserver and update normal tests #1545

Merged
merged 8 commits into from
Dec 5, 2022

Conversation

danipaniii
Copy link
Contributor

@danipaniii danipaniii commented Nov 25, 2022

In a meeting we discussed about implementing integration tests for the DynamicallyActivatableServiceObserver and with this PR those should be implemented.

Reference: #1527


This change is Reviewable

@danipaniii danipaniii changed the title Adding integration Tests for DynamicallyActivatableServiceObserver and update normal tests Adding integration tests for DynamicallyActivatableServiceObserver and update normal tests Nov 25, 2022
@codecov
Copy link

codecov bot commented Nov 25, 2022

Codecov Report

Merging #1545 (96b82a4) into master (6b9c5d1) will increase coverage by 0.04%.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1545      +/-   ##
============================================
+ Coverage     77.46%   77.50%   +0.04%     
  Complexity     2319     2319              
============================================
  Files           240      240              
  Lines          7728     7728              
  Branches        923      923              
============================================
+ Hits           5986     5989       +3     
+ Misses         1354     1351       -3     
  Partials        388      388              
Impacted Files Coverage Δ
...entation/transformer/AbstractClassTransformer.java 83.81% <0.00%> (-0.95%) ⬇️
...it/ocelot/core/exporter/JaegerExporterService.java 72.88% <0.00%> (+6.78%) ⬆️

Copy link
Contributor

@heiko-holz heiko-holz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3, 2 of 2 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @danipaniii)

@heiko-holz heiko-holz merged commit 25ccb69 into inspectIT:master Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants