Closes #1574: [Bug] - Span attributes not added when obfuscator is enabled

[heiko-holz]

Closes #1574

---

This change is 

[quandor]

Reviewed 8 of 8 files at r1, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @heiko-holz)

---

inspectit-ocelot-core/src/main/java/rocks/inspectit/ocelot/core/exporter/OtlpTraceExporterService.java line 66 at r1 (raw file):

            OtlpTraceExporterSettings otlp = configuration.getExporters().getTracing().getOtlp();

            String endpoint = otlp.getEndpoint();

I saw that code in three different places so far. Is it possible to move that into otlp.getEndpoint()? In that way we would have easily at a single place.

---

inspectit-ocelot-core/src/test/java/rocks/inspectit/ocelot/core/exporter/ExporterServiceIntegrationTestBase.java line 297 at r1 (raw file):

                }

                return (childSpan.get().getParentSpanId().equals(parentSpan.get().getSpanId()));

Those enclosing parenthesis are unnecessary, or am I missing something?

---

inspectit-ocelot-core/src/test/java/rocks/inspectit/ocelot/core/privacy/obfuscation/ObfuscationManagerTest.java line 294 at r1 (raw file):

            verifyNoMoreInteractions(span);

            // TODO: Boolean

Das TODO sieht für mich erledigt aus ;-)

[heiko-holz]

inspectit-ocelot-core/src/main/java/rocks/inspectit/ocelot/core/exporter/OtlpTraceExporterService.java line 66 at r1 (raw file):

Previously, quandor (Jochen Just) wrote…

I saw that code in three different places so far. Is it possible to move that into otlp.getEndpoint()? In that way we would have easily at a single place.

Yeah, good idea.
I agree.

However, I'd first like to talk to you about the "http-padding" that I introduced.

[heiko-holz]

inspectit-ocelot-core/src/test/java/rocks/inspectit/ocelot/core/exporter/ExporterServiceIntegrationTestBase.java line 297 at r1 (raw file):

Previously, quandor (Jochen Just) wrote…

Those enclosing parenthesis are unnecessary, or am I missing something?

Thanks for spotting.
I removed the redundant parentheses.

[heiko-holz]

Reviewable status: 3 of 14 files reviewed, 3 unresolved discussions (waiting on @quandor)

---

inspectit-ocelot-core/src/test/java/rocks/inspectit/ocelot/core/privacy/obfuscation/ObfuscationManagerTest.java line 294 at r1 (raw file):

Previously, quandor (Jochen Just) wrote…

Das TODO sieht für mich erledigt aus ;-)

Yes, indeed.
I left it to see if the reviewer sees it ;) /joking

[quandor]

Reviewed 11 of 11 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @heiko-holz)

---

inspectit-ocelot-core/src/main/java/rocks/inspectit/ocelot/core/exporter/OtlpTraceExporterService.java line 66 at r1 (raw file):

Previously, heiko-holz (Heiko Holz) wrote…

Yeah, good idea.
I agree.

However, I'd first like to talk to you about the "http-padding" that I introduced.

LGTM

---

inspectit-ocelot-core/src/test/java/rocks/inspectit/ocelot/core/exporter/ExporterServiceIntegrationTestBase.java line 297 at r1 (raw file):

Previously, heiko-holz (Heiko Holz) wrote…

Thanks for spotting.
I removed the redundant parentheses.

👍