Export step during frontend build is successful #1585
Conversation
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @quandor)
components/inspectit-ocelot-configurationserver/build.gradle line 52 at r1 (raw file):
} def checkCodeStyleFrontend = tasks.register('formatFrontend', YarnTask) {
shall the def and the task itself have the same naming, i.e., consistent use of checkCodeStyleFrontend or fromatFrontend?
Or do we need to differentiate them?
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @heiko-holz)
components/inspectit-ocelot-configurationserver/build.gradle line 52 at r1 (raw file):
Previously, heiko-holz (Heiko Holz) wrote…
shall the
defand thetaskitself have the same naming, i.e., consistent use ofcheckCodeStyleFrontendorfromatFrontend?
Or do we need to differentiate them?
We do not need to differentiate them. Hence I will go for checkCodeStyleFrontend as variable name and task name.
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @quandor)
This change is