Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declares dependencies more explicit #1589

Merged
merged 6 commits into from
Mar 16, 2023
Merged

Declares dependencies more explicit #1589

merged 6 commits into from
Mar 16, 2023

Conversation

quandor
Copy link
Contributor

@quandor quandor commented Mar 15, 2023

  • Guava is declared explicitly as a dependency since it is directly used by the projects.
  • Some build files no longer emit warnings
  • The (hopefully) last dependency version is moved to gradle.properties
  • third party license file is up to date

This change is Reviewable

Copy link
Contributor

@heiko-holz heiko-holz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @quandor)

@quandor quandor merged commit 42fb993 into inspectIT:master Mar 16, 2023
@quandor quandor deleted the better_dependencies branch March 16, 2023 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants