-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add IPv6 support to snapshot socket
#1812
Conversation
While you're working on this, it would be nice to print the
See #1776 (comment) (could be done in a different PR) |
1c8935d
to
8187aec
Compare
040330e
to
8a02327
Compare
I'll suggest to rebase this on top of #1895, the result code will be much simpler IMO. |
It is really funny because I would have suggest you to rebase on top of mine. |
I don't have any issue. Let's get this in and then I'll rebase mine on top. |
I also can implement ipv6 support on top of #1895, so we don't waste time reviewing this. |
From my point of view, it makes much more sense to rebased this on top of the refactoring introduced in #1895, which IMO, is ready to go. |
If I rebase this PR on top of the refactoring one, it will just delay its merge. |
8a02327
to
c190c34
Compare
a7e7f8b
to
a1c5f61
Compare
62a7378
to
61fb17c
Compare
I rebased everything and the unit test confirms everything is OK, so it is time to merge this PR. |
61fb17c
to
7377d93
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, some minor comments.
Remove
func parseIPv4(ipU32 uint32) string { |
Signed-off-by: Francis Laniel <flaniel@linux.microsoft.com>
7377d93
to
d5c64e9
Compare
Signed-off-by: Francis Laniel <flaniel@linux.microsoft.com>
Signed-off-by: Francis Laniel <flaniel@linux.microsoft.com>
d5c64e9
to
22f144d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for handling all the comments.
Thank you for the review! |
Hi.
This PR adds IPv6 support to
snapshot socket
:$ python >>> import socket >>> s = socket.socket(socket.AF_INET6, socket.SOCK_STREAM) >>> s.bind(('::1', 8082, 0, 0)) >>> s.listen(5) zsh: suspended python3 $ sudo ig snapshot socket --host CONTAINER PROTOCOL LOCAL REMOTE STATUS ... TCP ::1:8082 :::0 LISTEN ...
Best regards.