ci: Make AKS cluster name unique. #1940
Conversation
This avoids issues where we try to create an already existing cluster. The max name length should be safe as it would be: ig-ci-aks-arm64-AzureLinux-32767 Which is 32 characters long, which is far below the 63 characters limitation of AKS [1]. Signed-off-by: Francis Laniel <flaniel@linux.microsoft.com> [1]: https://learn.microsoft.com/en-us/troubleshoot/azure/azure-kubernetes/aks-common-issues-faq#what-naming-restrictions-are-enforced-for-aks-resources-and-parameters-
eiffel-fl
force-pushed
the
francis/aks-salt
branch
from
e3d8527
to
f08f892
Compare
|
The change is looking good. My only concern is how would we ensure there isn't any dangling clusters? Also, do we have a run against |
The CI step to remove it always executed.
Not for the moment, I will push something. |
I tested and it was OK there. |
Makes sense. I was also thinking for scenarios if the deletion job itself has issues (downtime from Azure/GH) but perhaps we can check CI resource group in future if that even happens. |
|
Thank you for the review! |
This avoids issues where we try to create an already existing cluster.