Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ig documentation for some trace tools #1949

Merged
merged 3 commits into from
Aug 29, 2023
Merged

Conversation

eiffel-fl
Copy link
Member

Hi.

This PR removes the TODOs regarding ig documentation for trace tools.

Best regards.

alban
alban previously requested changes Aug 14, 2023
Copy link
Member

@alban alban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! A few things to fix and some suggestions. It should be good after that.

docs/gadgets/trace/dns.md Outdated Show resolved Hide resolved
docs/gadgets/trace/dns.md Outdated Show resolved Hide resolved
docs/gadgets/trace/fsslower.md Outdated Show resolved Hide resolved
docs/gadgets/trace/fsslower.md Outdated Show resolved Hide resolved
docs/gadgets/trace/dns.md Outdated Show resolved Hide resolved
docs/gadgets/trace/dns.md Outdated Show resolved Hide resolved
docs/gadgets/trace/fsslower.md Outdated Show resolved Hide resolved
docs/gadgets/trace/oomkill.md Show resolved Hide resolved
Signed-off-by: Francis Laniel <flaniel@linux.microsoft.com>
Signed-off-by: Francis Laniel <flaniel@linux.microsoft.com>
Signed-off-by: Francis Laniel <flaniel@linux.microsoft.com>
Copy link
Member

@mauriciovasquezbernal mauriciovasquezbernal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@eiffel-fl
Copy link
Member Author

Thank you for the reviews!

@eiffel-fl eiffel-fl merged commit f376bd2 into main Aug 29, 2023
46 checks passed
@eiffel-fl eiffel-fl deleted the francis/todo-ig-docs branch August 29, 2023 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants