cri: Drop support for CRI v1alpha2 #1965
Conversation
mqasimsarfraz
requested review from
blanquicet,
eiffel-fl,
alban and
mauriciovasquezbernal
as code owners
Currently, we support CRI v1/v1apha2 simultaneously. The approach
we were using (via unsafe.Pointer) works fine till cri-api v1.27.x
but since cri-api v1.28.x added a field ('user_specified_image' field to type 'ImageSpec')
it breaks the conversion.
The main reason to support both the CRI API version was
to support older version of containerd (1.4.x), which has already been
addressed since we migrated to using containerd API directly. So this change
doen't effect containerd runtimeclient in anyway. In terms of CRI-O, this
means we will now only support CRI-O clusters v1.20.0+ (Kubernetes: v1.20.0+)
Signed-off-by: Qasim Sarfraz <qasimsarfraz@microsoft.com>
Signed-off-by: Qasim Sarfraz <qasimsarfraz@microsoft.com>
mqasimsarfraz
force-pushed
the
qasim/drop-support-for-v1alpha2
branch
from
82be723
to
7551448
Compare
Done
Good idea. I created a commit to document it. Please let me know if it looks good! |
|
|
||
| By default, `ig` will try to communicate with the Docker Engine | ||
| API and the CRI API of containerd and CRI-O: | ||
| **Note:** We only support CRI v1 meaning that only CRI-O v1.20+ (compatible with Kubernetes v1.20+) is supported. |
There was a problem hiding this comment.
This note and the details of support for containerd should be moved away for this "Usage" section into docs/requirements.md. At the moment, docs/requirements.md only has one section about the kernel config. It could have another section about Kubernetes & container runtimes.
Thanks, I will merge this one and open a separate PR for documentation. |
Currently, we support CRI v1/v1alpha2 simultaneously. The approach we were using (via
unsafe.Pointer) works fine till cri-api v1.27.x but since cri-api v1.28.x added a field ('user_specified_image' field to type 'ImageSpec') it breaks the conversion.The main reason to support both the CRI API version was to support older version of containerd (1.4.x), which has already been addressed since we migrated to container API directly. So this changes doesn't effect containerd runtimeclient in anyway. In terms of CRI-O, this means we will now only support CRI-O clusters newer than Kubernetes version: v1.20.0.