Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring Kubernetes labels #1999

Merged
merged 1 commit into from
Sep 7, 2023

Conversation

nlamirault
Copy link
Contributor

@nlamirault nlamirault commented Sep 5, 2023

[Support Kubernetes recommended labels and additional labels]

How to use

helm template .

Testing done

Manifests seems valid. Ex:

---
# Source: gadget/templates/serviceaccount.yaml
apiVersion: v1
kind: ServiceAccount
metadata:
  labels:
    helm.sh/chart: gadget-1.0.0
    app.kubernetes.io/name: gadget
    app.kubernetes.io/instance: release-name
    app.kubernetes.io/component: controller
    app.kubernetes.io/version: "1.0.0"
    app.kubernetes.io/managed-by: Helm
  name: release-name-gadget
  namespace: gadget

@mqasimsarfraz
Copy link
Member

@nlamirault Thanks for the contribution. The changes are looking great with a quick test.

But I see that the CI is failing since it detect changes in deploy.yaml (used by kubectl gadget deploy) since we don't want helm related labels in it. Perhaps we can guard these labels with skipLabels (default false) value and set it to true here?

@mqasimsarfraz
Copy link
Member

Thanks for handling the comments. Can you please create a single commit for all the changes ? Afterwards, it is ready to go!

Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
Copy link
Member

@mqasimsarfraz mqasimsarfraz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mqasimsarfraz
Copy link
Member

Thanks for the contribution!

@mqasimsarfraz mqasimsarfraz merged commit de1801e into inspektor-gadget:main Sep 7, 2023
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants