ci: Use federated credential to login to Azure. #2013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eiffel-fl
requested review from
mauriciovasquezbernal and
mqasimsarfraz
as code owners
eiffel-fl
force-pushed
the
citest/francis/caa-identitfy
branch
from
3dbe1ad
to
aed9360
Compare
eiffel-fl
force-pushed
the
citest/francis/caa-identitfy
branch
from
aed9360
to
99105f7
Compare
eiffel-fl
force-pushed
the
citest/francis/caa-identitfy
branch
from
99105f7
to
3ea8f66
Compare
eiffel-fl
force-pushed
the
citest/francis/caa-identitfy
branch
from
3ea8f66
to
17942e9
Compare
eiffel-fl
force-pushed
the
citest/francis/caa-identitfy
branch
from
17942e9
to
ad43355
Compare
Signed-off-by: Francis Laniel <flaniel@linux.microsoft.com>
eiffel-fl
force-pushed
the
citest/francis/caa-identitfy
branch
from
ad43355
to
0cf435c
Compare
|
Last CI run worked fine: |
mqasimsarfraz
approved these changes
Sep 21, 2023
There was a problem hiding this comment.
LGTM! The login step is green now!
Great work! It should save us from the pain of credential renewal.
|
Thank you for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.