ci: Fix uploading ig container image as artifact #2043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: 463f5a8 ("ci: Publish ig container images.") Signed-off-by: Mauricio Vásquez <mauriciov@microsoft.com>
mauriciovasquezbernal
requested review from
eiffel-fl and
mqasimsarfraz
as code owners
eiffel-fl
approved these changes
Sep 18, 2023
No, the artifact is never used, however it's still useful for manual debugging in some cases and testing in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: 463f5a8 ("ci: Publish ig container images.")
It was causing this step to fail with
Warning: No files were found with the provided path: /tmp/ig-container-image-linux-amd64.tar. No artifacts will be uploaded.Ref https://github.com/inspektor-gadget/inspektor-gadget/actions/runs/6184453746/job/16790129503
It wasn't causing any other issue as these artifacts are not being used anywhere.