pkg/gadget-service: migrate gRPC API of the gadget-service to a separate package #2067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change splits the gRPC API we use for communication between kubectl-gadget and gadgettracermanager and the internal gadgettracermanager gRPC API (used for housekeeping jobs). As we plan to communicate the former to third parties and also use it for other environments (communication between ig and a new client (probably called gadgetctl)), it makes sense to have it in a separate package that's better documented and stable. Signed-off-by: Michael Friese <mfriese@microsoft.com>
flyth
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change splits the gRPC API we use for communication between kubectl-gadget and gadgettracermanager and the internal gadgettracermanager gRPC API (used for housekeeping jobs). As we plan to communicate the former to third parties and also use it for other environments (communication between ig and a new client (probably called
gadgetctl)), it makes sense to have it in a separate package that's better documented and stable.Part of #1681