Remove bcc image #2094
Merged
Remove bcc image #2094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eiffel-fl
requested review from
mauriciovasquezbernal,
mqasimsarfraz and
alban
as code owners
This was
linked to
issues
Oct 2, 2023
Closed
eiffel-fl
force-pushed
the
francis/deprecate-bcc
branch
2 times, most recently
from
cda5b38
to
4606eae
Compare
There was a problem hiding this comment.
Looks good mostly, still missing some places to be updated:
- Required kernel versions:
inspektor-gadget/docs/requirements.md
Line 41 in 2be68e5
- Contributing guide docs/devel/CONTRIBUTING.md
eiffel-fl
force-pushed
the
francis/deprecate-bcc
branch
7 times, most recently
from
1cd9dcb
to
8e6334e
Compare
mauriciovasquezbernal
approved these changes
Oct 3, 2023
We now only have one flavour of the gadget container image, there is no sense
naming it default.
The removal of standardtracer code was done by the following gopatch [1]:
@@
@@
t.tracer, err = tracer.NewTracer(...)
if err != nil {
- trace.Status.OperationWarning = fmt.Sprint(...)
- // fallback to standard tracer
- log.Infof(...)
- t.tracer, err = standardtracer.NewTracer(...)
- if err != nil {
- trace.Status.OperationError = fmt.Sprintf("failed to create tracer: %s", err)
- return
- }
+ trace.Status.OperationError = fmt.Sprintf("failed to create tracer: %s", err)
+ return
}
Signed-off-by: Francis Laniel <flaniel@linux.microsoft.com>
[1]: https://github.com/uber-go/gopatch
Signed-off-by: Francis Laniel <flaniel@linux.microsoft.com>
eiffel-fl
force-pushed
the
francis/deprecate-bcc
branch
from
8e6334e
to
a07b5a8
Compare
|
Thank you for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi.
This PR deprecates the
bccimage and remove any mention ofdefaultas we only have one image now.Best regards.