ci: Only release image without CVEs. #2114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
I think it'll become a bottleneck in our workflow not being able to push those images if there is a known CVE on the base image. I'm ok with having this for the release workflow, there we could wait until the base image is fixed, and if it's taking too long to change it or find another solution.
eiffel-fl
force-pushed
the
francis/publish-scan
branch
from
5742270
to
a797747
Compare
eiffel-fl
changed the title
mauriciovasquezbernal
approved these changes
Oct 11, 2023
There was a problem hiding this comment.
I think it's fine. @alban do you have any opinions on this one?
Signed-off-by: Francis Laniel <flaniel@linux.microsoft.com>
eiffel-fl
force-pushed
the
francis/publish-scan
branch
from
a797747
to
9111d0a
Compare
eiffel-fl
changed the title
alban
approved these changes
Nov 9, 2023
|
Thank you for the reviews! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi.
I marked this PR as RFC as maybe we should be able to bypass this.
On the other hand, this is not a good thing to publish flawed images.
Best regards.