{Makefile, ci}: Append .exe to our Windows binaries. #2120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eiffel-fl
requested review from
alban and
mauriciovasquezbernal
as code owners
eiffel-fl
force-pushed
the
francis/windows-exe
branch
from
b19845b
to
b27c0ac
Compare
eiffel-fl
changed the title
eiffel-fl
changed the title
eiffel-fl
force-pushed
the
francis/windows-exe
branch
from
b27c0ac
to
f3baa9e
Compare
|
Do you know if we will need changes here, https://github.com/inspektor-gadget/inspektor-gadget/blob/main/.krew.yaml#L67 ? I mean how the binary is called |
eiffel-fl
force-pushed
the
francis/windows-exe
branch
from
f3baa9e
to
c0e325b
Compare
Good catch! |
True. It can be tricky. Hopefully we won't need any further changes 🤞 Also, I believe changes to |
Suggested-by: Michael Friese <mfriese@microsoft.com> Signed-off-by: Francis Laniel <flaniel@linux.microsoft.com>
eiffel-fl
force-pushed
the
francis/windows-exe
branch
from
c0e325b
to
4fe33dd
Compare
mqasimsarfraz
approved these changes
Oct 10, 2023
There was a problem hiding this comment.
LGTM, thanks!
I tested it locally and it worked fine:
→ ls -la ~/.krew/bin/kubectl-gadget.exe
ls: cannot access '/home/qasim/.krew/bin/kubectl-gadget.exe': No such file or directory
→ cat gadget.yaml | grep 'os: windows' -A 5
os: windows
arch: amd64
uri: https://github.com/inspektor-gadget/inspektor-gadget/releases/download/v0.21.0/kubectl-gadget-windows-amd64-v0.21.0.tar.gz
sha256: 90c5dec8b4790b0f8e68a1e32373a450aef29d4c50f9f89c051c8dce498b87ec
bin: kubectl-gadget.exe
→ KREW_OS=windows KREW_ARCH=amd64 kubectl-krew install --manifest=gadget.yaml --archive=kubectl-gadget-windows-amd64.tar.gz
Installing plugin: gadget
Installed plugin: gadget
\
| Use this plugin:
| kubectl gadget
| Documentation:
| https://github.com/inspektor-gadget/inspektor-gadget
| Caveats:
| \
| | Inspektor Gadget needs to be deployed to each node:
| |
| | $ kubectl gadget deploy
| |
| | Read the documentation available at https://github.com/inspektor-gadget/inspektor-gadget
| | to get more information about the server side installation process.
| /
/
→ ls -la ~/.krew/bin/kubectl-gadget.exe
lrwxrwxrwx 1 qasim qasim 57 Okt 10 10:38 /home/qasim/.krew/bin/kubectl-gadget.exe -> /home/qasim/.krew/store/gadget/v0.21.0/kubectl-gadget.exe
|
Thank you for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested-by: Michael Friese mfriese@microsoft.com