Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: panic issue due to unavailable host network namespace inode #2123

Merged

Conversation

Iiqbal2000
Copy link
Contributor

Resolve a panic issue when getting an unavailable host namespace. Add error format to two functions: WithLinuxNamespaceEnrichment and isHostNamespace.

Fixes #1858

@alban
Copy link
Member

alban commented Oct 9, 2023

The patch looks good to me.

Could you add a Signed-off-by: line in your commit message?

@Iiqbal2000
Copy link
Contributor Author

Got it

Signed-off-by: Iiqbal2000 <iqbalhafizh2000@gmail.com>
@Iiqbal2000 Iiqbal2000 force-pushed the fix-panic-getting-host-net-ns-inode branch from 41f5476 to e9e6035 Compare October 10, 2023 14:27
@Iiqbal2000
Copy link
Contributor Author

@alban could you check my last commit?

Copy link
Member

@alban alban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

I'll wait until the CI completes.

@Iiqbal2000
Copy link
Contributor Author

Thank you, Alban :)

@alban alban merged commit ce4688f into inspektor-gadget:main Oct 12, 2023
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ig "panic: getting host net ns inode" when /host not available
2 participants