run: Add pull policy --pull flag
#2179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
burak-ok
requested review from
alban,
mqasimsarfraz and
mauriciovasquezbernal
|
I tried it together with @claudiamarcubina and it seems that it isn't working as expected for pull policy $ go run -exec "sudo -E" ./cmd/ig image pull ghcr.io/inspektor-gadget/gadget/trace_open:latest
$ go run -exec "sudo -E" ./cmd/ig image pull ghcr.io/inspektor-gadget/gadget/trace_exec:latest
$ go run -exec "sudo -E" ./cmd/ig image tag ghcr.io/inspektor-gadget/gadget/trace_exec:latest ghcr.io/inspektor-gadget/gadget/trace_open:latest
# ensure trace_open is actually trace_exec
$ go run -exec "sudo -E" ./cmd/ig run ghcr.io/inspektor-gadget/gadget/trace_exec:latest
$ go run -exec "sudo -E" ./cmd/ig run ghcr.io/inspektor-gadget/gadget/trace_open:latest
# verify trace_open is trace_open
$ go run -exec "sudo -E" ./cmd/ig run --pull always ghcr.io/inspektor-gadget/gadget/trace_open:latestIt seems oci-store used by |
I tested it locally and its interesting: ➭ go run --exec "sudo -E" ./cmd/ig/... image list
INFO[0000] Experimental features enabled
REPOSITORY TAG DIGEST
ghcr.io/burak-ok/trace_exec latest 30507a96ca40
ghcr.io/burak-ok/trace_open latest d798a768d944
➭ go run --exec "sudo -E" ./cmd/ig/... image tag ghcr.io/burak-ok/trace_open ghcr.io/burak-ok/trace_exec
INFO[0000] Experimental features enabled
Successfully tagged with ghcr.io/burak-ok/trace_exec:latest@sha256:d798a768d9449b13694aae2d0eb074e5f39cdddbc6a116fc26afe8a671afcfb9
➭ go run --exec "sudo -E" ./cmd/ig/... image list
INFO[0000] Experimental features enabled
REPOSITORY TAG DIGEST
ghcr.io/burak-ok/trace_exec latest d798a768d944
ghcr.io/burak-ok/trace_open latest d798a768d944
➭ go run --exec "sudo -E" ./cmd/ig/... run ghcr.io/burak-ok/trace_exec --pull always
INFO[0000] Experimental features enabled
RUNTIME.CONTAINERNAME PID COMM UID GID RET FNAME
minikube-docker 1894556888 1041 57564 -1
minikube-docker 1902313085 1041 57570 -1 -init
^C%
➭ go run --exec "sudo -E" ./cmd/ig/... image list
INFO[0000] Experimental features enabled
REPOSITORY TAG DIGEST
ghcr.io/burak-ok/trace_exec latest 30507a96ca40
ghcr.io/burak-ok/trace_open latest d798a768d944
➭ go run --exec "sudo -E" ./cmd/ig/... run ghcr.io/burak-ok/trace_exec --pull never
INFO[0000] Experimental features enabled
RUNTIME.CONTAINERNAME PID PPID COMM UID GID RETVAL
minikube-docker 64419 19274 bridge 0 0 0
minikube-docker 64425 19274 portmap 0 0 0 The first running gadget is clearly Just wanted to share - Fixing it :) |
burak-ok
force-pushed
the
burak/run/pull_policy
branch
from
4baa1e3
to
e16e297
Compare
That was totally correct. It didn't refer to the same I just had to "reload" the |
burak-ok
force-pushed
the
burak/run/pull_policy
branch
from
e16e297
to
d96a04f
Compare
Signed-off-by: Burak Ok <burakok@microsoft.com>
burak-ok
force-pushed
the
burak/run/pull_policy
branch
from
d96a04f
to
76ea94e
Compare
Signed-off-by: Burak Ok <burakok@microsoft.com>
Signed-off-by: Burak Ok <burakok@microsoft.com>
Signed-off-by: Burak Ok <burakok@microsoft.com>
burak-ok
force-pushed
the
burak/run/pull_policy
branch
from
76ea94e
to
bac8078
Compare
mauriciovasquezbernal
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
run: Add pull policy
--pullflag--pull missing(default) only pulls the image when it is missing--pull alwaysPulls always--pull neverNever pullsThe pull policy behavior is the same as Docker, but not the same as for K8s. For K8s in the default case the pull policy is missing, except when the
latesttag is used. Then it is always pullingFixes #2101
Slack Discussion: https://kubernetes.slack.com/archives/CSYL75LF6/p1697722813839619