-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: reorganise documentation with different main sections #2260
Conversation
This allows to test the website locally. Signed-off-by: Alban Crequy <albancrequy@linux.microsoft.com>
bc758e2
to
5ee8d37
Compare
I fixed the broken links. It is ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it goes into the right direction. Just a couple of comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason not to have script and traceloop here too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since they are built-in gadgets, they are in the builtin-gadgets section.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see the built-in gadgets section while testing locally. Did you forget git add docs/builtin-gadgets/_index.md
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right, I forgot it. It's added now.
The documentation now has the following main sections: - getting started: installation instructions split by target - core concepts - development - guides - built-in gadgets Signed-off-by: Alban Crequy <albancrequy@linux.microsoft.com>
Signed-off-by: Alban Crequy <albancrequy@linux.microsoft.com>
Since we want to move towards image-based gadgets instead of built-in gadgets, it does not make sense for the documentation to focus on built-in gadgets. Signed-off-by: Alban Crequy <albancrequy@linux.microsoft.com>
Signed-off-by: Alban Crequy <albancrequy@linux.microsoft.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I think it's a step on the right direction. Thanks for taking care of this.
docs: reorganise documentation
The documentation now has the following main sections:
How to use
Testing done