Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: reorganise documentation with different main sections #2260

Merged
merged 5 commits into from
Dec 6, 2023
Merged

Conversation

alban
Copy link
Member

@alban alban commented Nov 28, 2023

docs: reorganise documentation

The documentation now has the following main sections:

  • getting started: installation instructions split by target
  • core concepts
  • development
  • guides
  • built-in gadgets

How to use

make website-local-update

Testing done

image

This allows to test the website locally.

Signed-off-by: Alban Crequy <albancrequy@linux.microsoft.com>
@alban alban force-pushed the alban_docs3 branch 2 times, most recently from bc758e2 to 5ee8d37 Compare December 4, 2023 14:51
@alban alban marked this pull request as ready for review December 4, 2023 14:55
@alban
Copy link
Member Author

alban commented Dec 4, 2023

I fixed the broken links. It is ready for review.

Copy link
Member

@mauriciovasquezbernal mauriciovasquezbernal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it goes into the right direction. Just a couple of comments.

docs/devel/how-to-write-a-gadget.md Outdated Show resolved Hide resolved
docs/guides/run.md Show resolved Hide resolved

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason not to have script and traceloop here too?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since they are built-in gadgets, they are in the builtin-gadgets section.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see the built-in gadgets section while testing locally. Did you forget git add docs/builtin-gadgets/_index.md?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, I forgot it. It's added now.

The documentation now has the following main sections:

- getting started: installation instructions split by target
- core concepts
- development
- guides
- built-in gadgets

Signed-off-by: Alban Crequy <albancrequy@linux.microsoft.com>
Signed-off-by: Alban Crequy <albancrequy@linux.microsoft.com>
Since we want to move towards image-based gadgets instead of built-in
gadgets, it does not make sense for the documentation to focus on
built-in gadgets.

Signed-off-by: Alban Crequy <albancrequy@linux.microsoft.com>
Signed-off-by: Alban Crequy <albancrequy@linux.microsoft.com>
Copy link
Member

@mauriciovasquezbernal mauriciovasquezbernal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think it's a step on the right direction. Thanks for taking care of this.

@alban alban merged commit bbcde33 into main Dec 6, 2023
49 of 50 checks passed
@alban alban deleted the alban_docs3 branch December 6, 2023 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants