Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[integration-tests] Add helpers for Jobs #2261

Merged
merged 2 commits into from
Nov 29, 2023
Merged

Conversation

burak-ok
Copy link
Member

[integration-tests] Add helpers for Jobs

Adds two functions to help in the integration tests:

  1. JobCommand to create jobs
  2. WaitUntilJobCompleteCommand which waits until the job completes

Signed-off-by: Burak Ok <burakok@microsoft.com>
Copy link
Member

@eiffel-fl eiffel-fl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose we will use this in the future, so better to have functions for it right now.
I just have one comment, otherwise it is OK to merge as the CI is green.

integration/command.go Show resolved Hide resolved
Signed-off-by: Burak Ok <burakok@microsoft.com>
Copy link
Member

@mauriciovasquezbernal mauriciovasquezbernal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for cleaning it up!

@burak-ok burak-ok merged commit 3376460 into main Nov 29, 2023
50 checks passed
@burak-ok burak-ok deleted the burak/integration/job_helper branch November 29, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants