Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Polish arm64 trace exec #2277

Merged
merged 2 commits into from
Dec 8, 2023
Merged

Polish arm64 trace exec #2277

merged 2 commits into from
Dec 8, 2023

Conversation

eiffel-fl
Copy link
Member

Hi.

This PR polishes and removes workaround for trace_exec on arm64:

$ uname -m
aarch64
$ sudo ./ig-linux-arm64 trace exec --host
RUNTIME.CONTAINERNAME                    PID        PPID       COMM             RET ARGS                                                 
                                         5215       887        sh               0   /bin/sh -c iptables --version                        
                                         5216       5215       iptables         0   /usr/sbin/iptables --version                         
                                         ...                            
$ export IG_EXPERIMENTAL=true
$ sudo -E ./ig-linux-arm64 run francisregistry.azurecr.io/gadget/execs
INFO[0000] Experimental features enabled                
RUNTIME.CONTAINERNAME            PID               PPID              COMM              UID              GID              RETVAL          
^Z
[1]+  Stopped                 sudo -E ./ig-linux-arm64 run francisregistry.azurecr.io/gadget/execs
$ bg
[1]+ sudo -E ./ig-linux-arm64 run francisregistry.azurecr.io/gadget/execs &
$ docker run --rm hello-world
stupefied_goldwasser             5381              5361              hello             0                0                0               

Hello from Docker!
...

Best regards.

@eiffel-fl
trace/exec: Remove unneeded file.
10506bb 
all_loadlinks.go is no more needed since 65f0d30
("remove arm64 workaround in exec tracer") as this commit got rid of arm64
workaround.

Signed-off-by: Francis Laniel <flaniel@linux.microsoft.com>
@eiffel-fl
gadgets/trace_exec: Remove arm64 workaround.
0034cae 
This commit replicates 65f0d30 ("remove arm64 workaround in exec tracer").

Signed-off-by: Francis Laniel <flaniel@linux.microsoft.com>
mauriciovasquezbernal
mauriciovasquezbernal approved these changes Dec 7, 2023
View reviewed changes
Copy link
Member

@mauriciovasquezbernal mauriciovasquezbernal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for keeping it up in sync.

@eiffel-fl
Copy link
Member Author

Thank you for the review!

@eiffel-fl eiffel-fl merged commit 3c1a547 into main Dec 8, 2023
50 checks passed
@eiffel-fl eiffel-fl deleted the francis/arm64-polish branch December 8, 2023 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mauriciovasquezbernal mauriciovasquezbernal mauriciovasquezbernal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eiffel-fl @mauriciovasquezbernal