Enum conversion: fix loop variable captured in closure #2298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alban
requested review from
burak-ok and
mauriciovasquezbernal
as code owners
mauriciovasquezbernal
approved these changes
Dec 14, 2023
When iterating over the btf types, the loop variable was captured in the getter() closure. This caused enumSetter() to use the wrong btf type to get the enum value. To avoid this problem, this patch makes sure that the closures use a copy of the loop variable. Fixes: dcf979c Signed-off-by: Alban Crequy <albancrequy@linux.microsoft.com>
mauriciovasquezbernal
force-pushed
the
alban_loop_variable_capture1
branch
from
a335e87
to
a419558
Compare
burak-ok
approved these changes
Dec 15, 2023
|
Rebasing to pick #2300 up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When iterating over the btf types, the loop variable was captured in the getter() closure. This caused enumSetter() to use the wrong btf type to get the enum value.
To avoid this problem, this patch makes sure that the closures use a copy of the loop variable.
Fixes: dcf979c
Problem discovered when trying to implement enums in the dns gadget: #2204 (comment)