gadgets: Convert trace oomkill to image based gadget #2333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eiffel-fl
force-pushed
the
francis/img-oom
branch
from
82d71b9
to
1617a35
Compare
burak-ok
reviewed
Dec 28, 2023
eiffel-fl
force-pushed
the
francis/img-oom
branch
from
1617a35
to
62d1770
Compare
burak-ok
approved these changes
Dec 29, 2023
Signed-off-by: Francis Laniel <flaniel@linux.microsoft.com>
eiffel-fl
force-pushed
the
francis/img-oom
branch
5 times, most recently
from
c2579c9
to
20f4cce
Compare
Signed-off-by: Francis Laniel <flaniel@linux.microsoft.com>
eiffel-fl
force-pushed
the
francis/img-oom
branch
from
20f4cce
to
d0bc838
Compare
|
Thank you for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi.
This PR converts
trace oomkillto image based gadget:$ sudo -E ./ig run oomkills & francis/img-oom % u= [1] 90799 INFO[0000] Experimental features enabled RUNTIME.CONTAINERNAME FPID FUID FGID TPID PAGES FCOMM TCOMM $ docker run --name test-trace-oomkill -m 512M -it --rm busybox tail /dev/zeroo test-trace-oomkill 90914 0 0 90914 262144 tail tailBest regards.