Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use client-go informers instead of active polling #2347

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

matthyx
Copy link
Contributor

@matthyx matthyx commented Jan 9, 2024

use client-go informers instead of active polling

Use https://pkg.go.dev/k8s.io/client-go/informers instead of active polling in the K8sInventoryCache component.

How to use

[ describe what reviewers need to do in order to validate this PR ]

Testing done

I don't know exactly how to test this change, help needed here.

Signed-off-by: Matthias Bertschy <matthias.bertschy@gmail.com>
Copy link
Member

@burak-ok burak-ok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the improvement and PR.
Really appreciated 👍

Copy link
Member

@burak-ok burak-ok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR tests ran successfully and also tried it locally.
Thanks again for the contribution

@burak-ok burak-ok merged commit 79ce3ef into inspektor-gadget:main Jan 9, 2024
53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants