-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add checks for lost samples and empty record in capabilities tracer #2350
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi!
Thank you for the fix!
I will run the CI and test it locally in the meanwhile but everything looks fine from code inspection.
Can you please git blame
and add a Fixes:
tag to your commit message?
Best regards.
@eiffel-fl what should I do with |
Sorry, use |
Ok will do right after my daily |
@eiffel-fl like that? I have added it to the line before |
Normally, we also add the title of the commit within bracket, like: I tested it locally and everything seems to be OK, sadly I cannot reproduce your bug: $ sudo ./ig trace capabilities (remotes/matthyx/panic) %
RUNTIME.CONTAINERNAME PID COMM SYSCALL CAP CAPNAME AUDIT VERDICT
practical_dhawan 18337 chown fchownat 0 CHOWN 1 Allow
practical_dhawan 18337 chown fchownat 0 CHOWN 1 Allow
practical_dhawan 18338 chmod fchmodat 3 FOWNER 1 Allow
practical_dhawan 18338 chmod fchmodat 4 FSETID 1 Allow Thinking more to this, maybe you can add a sentence in the commit message about your modification avoiding a panic? |
Fixes: 39aefb9 ("pkg/gadgets: Add capabilities CO-RE tracer.") Signed-off-by: Matthias Bertschy <matthias.bertschy@gmail.com>
done |
Thank you for the fix! |
add checks for lost samples and empty record in capabilities tracer
https://kubernetes.slack.com/archives/CSYL75LF6/p1704806538839969
How to use
[ describe what reviewers need to do in order to validate this PR ]
Testing done
[Describe the testing you have done before submitting this PR. Please include both the commands you issued as well as the output you got.]