Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integration: Use correct type for netns. #2357

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

eiffel-fl
Copy link
Member

Fixes: 0f81d1d ("integration: Add test for run trace sni")

@eiffel-fl eiffel-fl force-pushed the francis/run_trace_sni_test_fix branch 4 times, most recently from a9f5a39 to 719853f Compare January 12, 2024 16:32
Fixes: 0f81d1d ("integration: Add test for run trace sni")
Signed-off-by: Francis Laniel <flaniel@linux.microsoft.com>
Signed-off-by: Qasim Sarfraz <qasimsarfraz@microsoft.com>
Copy link
Member

@mqasimsarfraz mqasimsarfraz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Since I made some adjustments, I will wait for another approval before merging it.

Copy link
Member

@mauriciovasquezbernal mauriciovasquezbernal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it locally, before this PR the tests failed, now it works fine. Thanks you both for this fix!

Copy link
Member

@burak-ok burak-ok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, too.

@mauriciovasquezbernal mauriciovasquezbernal merged commit 46a8fad into main Jan 15, 2024
53 checks passed
@mauriciovasquezbernal mauriciovasquezbernal deleted the francis/run_trace_sni_test_fix branch January 15, 2024 15:23
@eiffel-fl
Copy link
Member Author

LGTM! Since I made some adjustments, I will wait for another approval before merging it.

Thank you for the modifications!
This was a pain to find what would work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants