Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integration/TraceOOMKill: Don't check triggered uid & gid #2411

Merged
merged 1 commit into from
Jan 26, 2024

Conversation

burak-ok
Copy link
Member

integration/TraceOOMKill: Don't check triggered uid & gid

It can't be assured that our tail process will trigger the oomkill. It could be another process with another uid and gid

Example

Locally I got these multiple of 2 events. One time tail triggered the oom and another time conmon triggered it

        {"runtime":{"runtimeName":"cri-o","containerId":"dd176d59db623d05640f601d4d99af0df12b165e0493426cee88039fc44cb779","containerImageName":"docker.io/library/busybox:latest"},"k8s":{"node":"minikube-cri-o","namespace":"test-trace-oomkill-2366462858275538090","podName":"test-pod","podLabels":{"run":"test-pod"},"containerName":"test-pod-container"},"timestamp":1706176347489993010,"type":"normal","mountnsid":4026532886,"kpid":295521,"kcomm":"tail","pages":32768,"tpid":295273,"tuid":0,"tgid":0,"tcomm":"conmon"}
        {"runtime":{"runtimeName":"cri-o","containerId":"dd176d59db623d05640f601d4d99af0df12b165e0493426cee88039fc44cb779","containerImageName":"docker.io/library/busybox:latest"},"k8s":{"node":"minikube-cri-o","namespace":"test-trace-oomkill-2366462858275538090","podName":"test-pod","podLabels":{"run":"test-pod"},"containerName":"test-pod-container"},"timestamp":1706176347573634121,"type":"normal","mountnsid":4026532886,"kpid":295522,"kcomm":"tail","pages":32768,"tpid":295522,"tuid":1000,"tgid":2000,"tcomm":"tail"}

@burak-ok burak-ok marked this pull request as ready for review January 25, 2024 12:18
Copy link
Member

@eiffel-fl eiffel-fl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just add the corresponding Fixes: to your commit message.

It can't be assured that our `tail` process will trigger the oomkill. It
could be another process with another uid and gid

Fixes: efd6f97
Signed-off-by: Burak Ok <burakok@microsoft.com>
@burak-ok burak-ok merged commit 54fe1e7 into main Jan 26, 2024
56 checks passed
@burak-ok burak-ok deleted the burak/integration/oomkill branch January 26, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants