Add trace_tcp image based gadget #2428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
claudiamarcubina
requested review from
eiffel-fl and
mauriciovasquezbernal
as code owners
claudiamarcubina
force-pushed
the
claudia/convert-trace-tcp-gadget
branch
from
fa68228
to
382d72d
Compare
eiffel-fl
reviewed
Jan 31, 2024
claudiamarcubina
force-pushed
the
claudia/convert-trace-tcp-gadget
branch
from
382d72d
to
e3ce6a3
Compare
8 tasks
claudiamarcubina
force-pushed
the
claudia/convert-trace-tcp-gadget
branch
2 times, most recently
from
66869c7
to
836c5a6
Compare
eiffel-fl
reviewed
Feb 5, 2024
Signed-off-by: Claudia Marcu <claudiamarcu@microsoft.com>
Signed-off-by: Claudia Marcu <claudiamarcu@microsoft.com>
claudiamarcubina
force-pushed
the
claudia/convert-trace-tcp-gadget
branch
from
836c5a6
to
e7d1666
Compare
mauriciovasquezbernal
approved these changes
Feb 5, 2024
Thank you as well for the valuable feedback! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This PR adds trace_tcp as image based gadget.
Feedback for fixing tests is welcome.
Resolves #2372
Thank you!