pkg/columns: Do not elide output when redirected. #2451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for working on this, it will be nice to have this. Also, what do you think about combining it with --no-trunc ? |
|
Maybe this should rather become an Otherwise we lose the possibility of formatting output for other targets (e.g. when used as a service and sending formatted output to another logserver or such), because only the local environment would be considered. |
eiffel-fl
force-pushed
the
francis/no-elipsis-redirect
branch
2 times, most recently
from
b991ec7
to
c266274
Compare
|
I just added the $ sudo -E ./ig image list | awk '{ printf "%s:%s\n", $1, $2 }' | tail -2
INFO[0000] Experimental features enabled
blocks:latest
ghcr.io/inspektor-gadget/gadgets/blocks:latest
$ sudo -E ./ig image list | awk '{ printf "%s:%s\n", $1, $3 }' | tail -2
INFO[0000] Experimental features enabled
blocks:sha256:2bea84b83af28cd47302dcf37fe115327637974c9db4d490b5a59c65df4c190c
ghcr.io/inspektor-gadget/gadgets/blocks:sha256:2bea84b83af28cd47302dcf37fe115327637974c9db4d490b5a59c65df4c190c |
flyth
reviewed
Feb 6, 2024
When used in Inspektor Gadget, output will not be truncated if it is not a terminal. Signed-off-by: Francis Laniel <flaniel@linux.microsoft.com>
eiffel-fl
force-pushed
the
francis/no-elipsis-redirect
branch
from
c266274
to
47d20c7
Compare
|
Thank you for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi.
This PR removes ellipsis when the output is not a terminal:
Best regards.