Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cri: check range before accessing imageRef #2455

Merged
merged 1 commit into from
Feb 5, 2024
Merged

Conversation

alban
Copy link
Member

@alban alban commented Feb 5, 2024

panic on enriching some imageRef fields:
panic: runtime error: index out of range [1] with length 1

Based on work from: @burak-ok

Fixes #2413

The patch originally comes from #2398

panic on enriching some imageRef fields:
panic: runtime error: index out of range [1] with length 1

Based on work from: Burak Ok <burakok@microsoft.com>

Signed-off-by: Alban Crequy <albancrequy@linux.microsoft.com>
Copy link
Member

@blanquicet blanquicet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from code inspection.

@alban alban merged commit 16777bb into main Feb 5, 2024
56 checks passed
@alban alban deleted the alban_digestFromRef branch February 5, 2024 21:10
@eiffel-fl
Copy link
Member

I guess you have earn the right to test the stable release process:
https://github.com/inspektor-gadget/inspektor-gadget/blob/main/docs/devel/release-process.md#making-a-bugfix-release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ig + cri-o panic on enriching some imageRef fields
3 participants